From 2182f72105033db025bb29e08319586112e53c5f Mon Sep 17 00:00:00 2001
From: Ariver <shanghai3168@gmail.com>
Date: Wed, 10 Jun 2026 19:37:25 +0800
Subject: [PATCH] Fix empty Space lane fill
---
C3.tools/round1-three-zone-linkage-fixture-qa.sh | 87 +++++++++++++++++++++++++++++++++++++++++++
1 files changed, 86 insertions(+), 1 deletions(-)
diff --git a/C3.tools/round1-three-zone-linkage-fixture-qa.sh b/C3.tools/round1-three-zone-linkage-fixture-qa.sh
index 93a8bc2..b32d5b8 100755
--- a/C3.tools/round1-three-zone-linkage-fixture-qa.sh
+++ b/C3.tools/round1-three-zone-linkage-fixture-qa.sh
@@ -531,9 +531,27 @@
and inner.get("y", 0) + inner.get("height", 0) <= outer.get("y", 0) + outer.get("height", 0) + tolerance
)
+def is_light_blue(color):
+ return (
+ color.get("alpha", 0) >= 0.98
+ and color.get("blue", 0) >= 0.98
+ and color.get("green", 0) >= 0.90
+ and color.get("red", 0) >= 0.80
+ and color.get("blue", 0) > color.get("red", 0) + 0.04
+ )
+
+def is_white(color):
+ return (
+ color.get("alpha", 0) >= 0.98
+ and color.get("red", 0) >= 0.98
+ and color.get("green", 0) >= 0.98
+ and color.get("blue", 0) >= 0.98
+ )
+
root = report.get("rootView", {})
groups = root.get("spaceLaneDisplayGroups", [])
segments = root.get("spaceLaneSegments", [])
+lane_background = root.get("spaceLaneBackgroundColor", {})
require(report.get("snapshotLoaded") is True, "snapshotLoaded must be true")
require(report.get("quickSwitchVisible") is True, "multi-display report must keep Quick Switch visible")
@@ -544,6 +562,8 @@
require(len(segments) == 5, "Space segment reports must contain five segments")
require(groups[0].get("spaceLabels") == ["A1", "A2", "A3"], "first Display group must contain A spaces")
require(groups[1].get("spaceLabels") == ["B1", "B2"], "second Display group must contain B spaces")
+require(lane_background.get("alpha", 1) <= 0.01, "Space Lane outer background must be transparent")
+require(root.get("spaceLaneCornerRadius") == 0, "Space Lane outer layer must not draw a rounded white rectangle")
first_group_frame = groups[0].get("visibleFrame", {})
second_group_frame = groups[1].get("visibleFrame", {})
@@ -556,9 +576,23 @@
for group in groups:
group_frame = group.get("visibleFrame", {})
labels = group.get("spaceLabels", [])
+ require(group.get("borderWidth") == 0, "Display group container must be borderless")
+ require(group.get("shadowOpacity") == 0, "Display group container must not add a floating shadow")
+ require(group.get("backgroundColor", {}).get("alpha", 0) >= 0.98, "Display group container must use an opaque system surface")
+ require(group.get("groupHorizontalPadding", 0) >= 24, "Display group horizontal padding must be widened")
for label in labels:
require(label in segments_by_label, f"segment report must include {label}")
require(contains(group_frame, segments_by_label[label].get("visibleFrame", {})), f"{label} must be inside its Display group")
+ first_segment = segments_by_label[labels[0]].get("visibleFrame", {})
+ last_segment = segments_by_label[labels[-1]].get("visibleFrame", {})
+ require(
+ first_segment.get("x", 0) - group_frame.get("x", 0) >= group.get("groupHorizontalPadding", 0) - 1.0,
+ "Display group leading padding must match widened padding"
+ )
+ require(
+ right_edge(group_frame) - right_edge(last_segment) >= group.get("groupHorizontalPadding", 0) - 1.0,
+ "Display group trailing padding must match widened padding"
+ )
for group in groups:
labels = group.get("spaceLabels", [])
@@ -578,6 +612,57 @@
require(len(focused) == 1, "exactly one Space segment must be focused")
require(focused[0].get("label") == "B1", "hovered multi-display Space must be B1")
require("focused" in focused[0].get("visualStates", []), "focused B1 segment must expose focused visual state")
+
+empty_segments = [
+ segment for segment in segments
+ if segment.get("windowCount") == 0
+]
+require(empty_segments, "multi-display visual fixture must include at least one empty Space")
+require(
+ {"A3", "B1"}.issubset({segment.get("label") for segment in empty_segments}),
+ "multi-display visual fixture must include the A3/B1 empty Space regression pair"
+)
+require(
+ all(segment.get("backgroundKind") == "clear" for segment in empty_segments),
+ "empty Spaces must not keep a dirty gray fill, even when focused/current/associated"
+)
+require(
+ all(not segment.get("gradientColors", []) for segment in empty_segments),
+ "empty Spaces must clear stale gradient colors"
+)
+require(
+ all(segment.get("backgroundColor", {}).get("alpha", 1) <= 0.01 for segment in empty_segments),
+ "empty Spaces must keep transparent fill"
+)
+require(
+ all(segment.get("shadowOpacity", 1) <= 0.01 for segment in empty_segments),
+ "empty Spaces must not draw a shadow that reads as an interior gray fill"
+)
+idle_occupied_segments = [
+ segment for segment in segments
+ if segment.get("windowCount", 0) > 0
+ and segment.get("isFocused") is not True
+ and segment.get("isCurrent") is not True
+ and segment.get("isAppAssociated") is not True
+ and segment.get("isWindowAssociated") is not True
+]
+require(idle_occupied_segments, "multi-display visual fixture must include an idle occupied Space")
+for segment in idle_occupied_segments:
+ gradient_colors = segment.get("gradientColors", [])
+ require(segment.get("backgroundKind") == "gradient", "idle occupied Spaces must use blue-white gradient fill")
+ require(len(gradient_colors) == 2, "idle occupied Space gradient must expose two color stops")
+ require(is_light_blue(gradient_colors[0]), "idle occupied Space gradient must start with pure light blue")
+ require(is_white(gradient_colors[1]), "idle occupied Space gradient must end with pure white")
+fullscreen_segments = [segment for segment in segments if segment.get("type") == "fullscreen"]
+require(fullscreen_segments, "multi-display visual fixture must include a fullscreen Space")
+for segment in fullscreen_segments:
+ marker_frame = segment.get("fullscreenMarkerFrame", {})
+ app_frame = segment.get("appFrame", {})
+ marker_center_ratio = segment.get("fullscreenMarkerCenterRatio", 0)
+ marker_mid_y = marker_frame.get("y", 0) + marker_frame.get("height", 0) / 2
+ app_mid_y = app_frame.get("y", 0) + app_frame.get("height", 0) / 2
+ require(0.36 <= marker_center_ratio <= 0.44, "fullscreen Space marker must use adaptive vertical centering")
+ require(abs(marker_mid_y - app_mid_y) <= 2, "fullscreen App label must remain centered in the marker")
print(json.dumps({
"displayGroups": [
@@ -626,7 +711,7 @@
run_report "$SCROLL_REPORT" "scroll-app-shelf:99999" "scroll-app-shelf:99999" 60 1
assert_app_shelf_scroll_report "$SCROLL_REPORT"
-run_report "$DISPLAY_GROUP_REPORT" "hover-space:4" "hover-space:4" 6 3 report-only multi-display
+run_report "$DISPLAY_GROUP_REPORT" "hover-space:4" "hover-space:4" 1 1 report-only multi-display
assert_display_group_report "$DISPLAY_GROUP_REPORT"
swift "$SCRIPT_DIR/window-logic-qa.swift" --expect-no-quick-switch >&2
--
Gitblit v1.9.3