From 3b4a0887d287c890092fc0845eeb57e9a5b03bcd Mon Sep 17 00:00:00 2001
From: Ariver <shanghai3168@gmail.com>
Date: Sun, 24 May 2026 16:56:30 +0800
Subject: [PATCH] Fix Split View fullscreen overlay detection
---
Scripts/window_logic_qa.sh | 96 ++++++++++++++++++++++++++++++++++++++++++++++++
1 files changed, 96 insertions(+), 0 deletions(-)
diff --git a/Scripts/window_logic_qa.sh b/Scripts/window_logic_qa.sh
index e898312..4990885 100755
--- a/Scripts/window_logic_qa.sh
+++ b/Scripts/window_logic_qa.sh
@@ -66,6 +66,11 @@
fi
}
+reset_dock_for_qa() {
+ killall Dock >/dev/null 2>&1 || true
+ sleep 1.5
+}
+
send_keycode() {
local keycode="$1"
local modifiers="${2:-}"
@@ -434,6 +439,93 @@
}
print("PASS fullscreen overlay above target: overlayLayer=\(tag[0].layer) targetLayer=\(target.layer)")
+case "split-geometry":
+ func isSingleFullscreenWindow(_ windowFrame: CGRect, on screenFrame: CGRect) -> Bool {
+ let widthMatches = abs(windowFrame.width - screenFrame.width) <= 12
+ let heightMatches = windowFrame.height >= screenFrame.height * 0.88
+ let horizontallyAligned = abs(windowFrame.midX - screenFrame.midX) <= 12
+ let verticallyAligned = abs(windowFrame.maxY - screenFrame.maxY) <= 32
+ return widthMatches && heightMatches && horizontallyAligned && verticallyAligned
+ }
+
+ func hasSplitViewFullscreenWindows(_ windows: [CGRect], on screenFrame: CGRect) -> Bool {
+ let clippedWindows = windows.map { $0.intersection(screenFrame) }
+ let tallWindows = clippedWindows
+ .filter { frame in
+ frame.height >= screenFrame.height * 0.86
+ && frame.width >= screenFrame.width * 0.20
+ && frame.width <= screenFrame.width * 0.86
+ && abs(frame.maxY - screenFrame.maxY) <= 32
+ }
+ .sorted { $0.minX < $1.minX }
+
+ guard tallWindows.count >= 2 else { return false }
+
+ for startIndex in tallWindows.indices {
+ var union = tallWindows[startIndex]
+ var lastMaxX = union.maxX
+
+ for window in tallWindows.dropFirst(startIndex + 1) {
+ let gap = window.minX - lastMaxX
+ if gap < -32 || gap > 48 {
+ break
+ }
+ union = union.union(window)
+ lastMaxX = max(lastMaxX, window.maxX)
+
+ let touchesLeft = abs(union.minX - screenFrame.minX) <= 32
+ let touchesRight = abs(union.maxX - screenFrame.maxX) <= 32
+ let coversWidth = union.width >= screenFrame.width * 0.92
+ let coversHeight = union.height >= screenFrame.height * 0.86
+ if touchesLeft && touchesRight && coversWidth && coversHeight {
+ return true
+ }
+ }
+ }
+
+ return false
+ }
+
+ let screen = CGRect(x: 0, y: 0, width: 1710, height: 1112)
+ let single = CGRect(x: 0, y: 39, width: 1710, height: 1073)
+ let splitHalf = [
+ CGRect(x: 0, y: 39, width: 853, height: 1073),
+ CGRect(x: 857, y: 39, width: 853, height: 1073)
+ ]
+ let splitThird = [
+ CGRect(x: 0, y: 39, width: 568, height: 1073),
+ CGRect(x: 572, y: 39, width: 1138, height: 1073)
+ ]
+ let desktopTiledWithLargeGap = [
+ CGRect(x: 0, y: 90, width: 700, height: 900),
+ CGRect(x: 900, y: 90, width: 700, height: 900)
+ ]
+ let desktopSideBySideBelowDock = [
+ CGRect(x: 0, y: 39, width: 856, height: 983),
+ CGRect(x: 854, y: 39, width: 856, height: 983)
+ ]
+ let halfOnly = [CGRect(x: 0, y: 39, width: 853, height: 1073)]
+
+ guard isSingleFullscreenWindow(single, on: screen) else {
+ fail("split geometry expected single fullscreen window to match")
+ }
+ guard hasSplitViewFullscreenWindows(splitHalf, on: screen) else {
+ fail("split geometry expected 50/50 Split View to match")
+ }
+ guard hasSplitViewFullscreenWindows(splitThird, on: screen) else {
+ fail("split geometry expected 33/67 Split View to match")
+ }
+ guard !hasSplitViewFullscreenWindows(desktopTiledWithLargeGap, on: screen) else {
+ fail("split geometry should not match ordinary tiled desktop windows")
+ }
+ guard !hasSplitViewFullscreenWindows(desktopSideBySideBelowDock, on: screen) else {
+ fail("split geometry should not match side-by-side desktop windows below the Dock")
+ }
+ guard !hasSplitViewFullscreenWindows(halfOnly, on: screen) else {
+ fail("split geometry should not match a single half-width window")
+ }
+ print("PASS split fullscreen geometry detection")
+
case "screen-count":
print("INFO screens=\(NSScreen.screens.count) frames=\(NSScreen.screens.map { NSStringFromRect($0.frame) })")
@@ -665,6 +757,7 @@
log "==> Preparing QA defaults"
defaults write "$DEFAULTS_DOMAIN" showDockIcon -bool true
+reset_dock_for_qa
log "==> Starting clean app instance"
prepare_isolated_app_instance
@@ -692,6 +785,9 @@
sleep 0.4
wait_swift_assert no-overlay
+log "==> QA split-view fullscreen geometry detection"
+swift_assert split-geometry
+
run_fullscreen_space_case() {
local dock_value="$1"
log "==> QA fullscreen Space: overlay stays above the current fullscreen app (showDockIcon=$dock_value)"
--
Gitblit v1.9.3