From efbfc27e0c813c31b570d72fded40eb91d07f2db Mon Sep 17 00:00:00 2001
From: Ariver <shanghai3168@gmail.com>
Date: Thu, 28 May 2026 21:01:19 +0800
Subject: [PATCH] Add AppKit tag navigation reordering
---
Scripts/window_logic_qa.sh | 207 ++++++++++++++++++++++++++++++++++++++++++++++++++-
1 files changed, 201 insertions(+), 6 deletions(-)
diff --git a/Scripts/window_logic_qa.sh b/Scripts/window_logic_qa.sh
index 4990885..f93b3f2 100755
--- a/Scripts/window_logic_qa.sh
+++ b/Scripts/window_logic_qa.sh
@@ -14,6 +14,8 @@
DEFAULTS_DOMAIN="$LAUNCH_AGENT_LABEL"
SHOW_DOCK_ICON_WAS_SET=false
SHOW_DOCK_ICON_VALUE=""
+APP_LANGUAGE_WAS_SET=false
+APP_LANGUAGE_VALUE=""
FULLSCREEN_QA_PID=""
CLICK_TOOL="${CLICK_TOOL:-$(command -v cliclick || true)}"
@@ -31,6 +33,10 @@
if value="$(defaults read "$DEFAULTS_DOMAIN" showDockIcon 2>/dev/null)"; then
SHOW_DOCK_ICON_WAS_SET=true
SHOW_DOCK_ICON_VALUE="$value"
+ fi
+ if value="$(defaults read "$DEFAULTS_DOMAIN" appLanguage 2>/dev/null)"; then
+ APP_LANGUAGE_WAS_SET=true
+ APP_LANGUAGE_VALUE="$value"
fi
}
@@ -50,6 +56,12 @@
fi
else
defaults delete "$DEFAULTS_DOMAIN" showDockIcon >/dev/null 2>&1 || true
+ fi
+
+ if [[ "$APP_LANGUAGE_WAS_SET" == true ]]; then
+ defaults write "$DEFAULTS_DOMAIN" appLanguage -string "$APP_LANGUAGE_VALUE"
+ else
+ defaults delete "$DEFAULTS_DOMAIN" appLanguage >/dev/null 2>&1 || true
fi
}
@@ -91,6 +103,26 @@
send_cmd_w() {
osascript -e 'tell application "System Events" to keystroke "w" using {command down}'
+}
+
+close_settings_window() {
+ osascript <<'OSA' >/dev/null 2>&1 || true
+tell application "System Events"
+ tell process "TagLauncher"
+ repeat 20 times
+ repeat with windowRef in windows
+ try
+ if (name of windowRef as text) is not "" then
+ click button 1 of windowRef
+ return
+ end if
+ end try
+ end repeat
+ delay 0.1
+ end repeat
+ end tell
+end tell
+OSA
}
dismiss_reopen_dialog() {
@@ -278,9 +310,10 @@
assert_swift="$(mktemp -t taglauncher-window-assert.XXXXXX.swift)"
coords_swift="$(mktemp -t taglauncher-window-coords.XXXXXX.swift)"
+settings_ax_swift="$(mktemp -t taglauncher-settings-ax.XXXXXX.swift)"
screens_swift="$(mktemp -t taglauncher-screens.XXXXXX.swift)"
fullscreen_swift="$(mktemp -t taglauncher-fullscreen-target.XXXXXX.swift)"
-trap 'cleanup; rm -f "$assert_swift" "$coords_swift" "$screens_swift" "$fullscreen_swift" "$LAUNCH_AGENT_BACKUP"' EXIT
+trap 'cleanup; rm -f "$assert_swift" "$coords_swift" "$settings_ax_swift" "$screens_swift" "$fullscreen_swift" "$LAUNCH_AGENT_BACKUP"' EXIT
cat >"$assert_swift" <<'SWIFT'
import AppKit
@@ -439,6 +472,20 @@
}
print("PASS fullscreen overlay above target: overlayLayer=\(tag[0].layer) targetLayer=\(target.layer)")
+case "fullscreen-settings":
+ guard tag.count == 2 else { fail("fullscreen settings expected 2 TagLauncher windows, got \(tag.count)") }
+ assertTagLayer(tag)
+ guard let target = windows.first(where: { $0.name == "TagLauncherFullscreenQATargetFullscreen" }) else {
+ fail("fullscreen target disappeared after opening settings; TagLauncher likely switched to another Space")
+ }
+ guard !tag[0].name.isEmpty, tag[1].name.isEmpty else {
+ fail("fullscreen settings order wrong: \(tag.map(\.name))")
+ }
+ guard tag.allSatisfy({ $0.layer > target.layer }) else {
+ fail("TagLauncher settings stack is not above fullscreen target")
+ }
+ print("PASS fullscreen settings above target: tagLayers=\(tag.map(\.layer)) targetLayer=\(target.layer)")
+
case "split-geometry":
func isSingleFullscreenWindow(_ windowFrame: CGRect, on screenFrame: CGRect) -> Bool {
let widthMatches = abs(windowFrame.width - screenFrame.width) <= 12
@@ -562,7 +609,7 @@
fputs("FAIL: could not find settings window bounds\n", stderr)
exit(1)
}
- print("\(Int(round(x + 523))) \(Int(round(y + 50)))")
+ print("\(Int(round(x + 625))) \(Int(round(y + 50)))")
case "export":
guard let settings = tag.first(where: { (($0[kCGWindowName as String] as? String) ?? "").isEmpty == false }),
let bounds = settings[kCGWindowBounds as String] as? NSDictionary,
@@ -587,8 +634,124 @@
let overlayX = dimension(overlayBounds, "X")
let overlayY = dimension(overlayBounds, "Y")
print("\(Int(round(overlayX + 120))) \(Int(round(overlayY + 160)))")
+case "fullscreen-target-center":
+ guard let target = raw.first(where: { ($0[kCGWindowName as String] as? String) == "TagLauncherFullscreenQATargetFullscreen" }),
+ let bounds = target[kCGWindowBounds as String] as? NSDictionary else {
+ fputs("FAIL: could not find fullscreen target bounds\n", stderr)
+ exit(1)
+ }
+ let x = dimension(bounds, "X")
+ let y = dimension(bounds, "Y")
+ let width = dimension(bounds, "Width")
+ let height = dimension(bounds, "Height")
+ print("\(Int(round(x + width / 2))) \(Int(round(y + height / 2)))")
default:
fputs("FAIL: unknown coords mode \(mode)\n", stderr)
+ exit(1)
+}
+SWIFT
+
+cat >"$settings_ax_swift" <<'SWIFT'
+import AppKit
+import ApplicationServices
+import Foundation
+
+let mode = CommandLine.arguments.dropFirst().first ?? ""
+let bundleID = "com.taglauncher.app"
+
+guard let app = NSRunningApplication.runningApplications(withBundleIdentifier: bundleID).first else {
+ fputs("FAIL: TagLauncher is not running\n", stderr)
+ exit(1)
+}
+
+let root = AXUIElementCreateApplication(app.processIdentifier)
+
+func copyAttribute(_ element: AXUIElement, _ attribute: CFString) -> CFTypeRef? {
+ var value: CFTypeRef?
+ let result = AXUIElementCopyAttributeValue(element, attribute, &value)
+ guard result == .success else { return nil }
+ return value
+}
+
+func stringAttribute(_ element: AXUIElement, _ attribute: CFString) -> String? {
+ copyAttribute(element, attribute) as? String
+}
+
+func titleCandidates(for element: AXUIElement) -> [String] {
+ [
+ stringAttribute(element, kAXTitleAttribute as CFString),
+ stringAttribute(element, kAXDescriptionAttribute as CFString),
+ stringAttribute(element, kAXValueAttribute as CFString),
+ stringAttribute(element, kAXHelpAttribute as CFString)
+ ].compactMap { $0 }.filter { !$0.isEmpty }
+}
+
+func children(of element: AXUIElement) -> [AXUIElement] {
+ if let values = copyAttribute(element, kAXChildrenAttribute as CFString) as? [AXUIElement] {
+ return values
+ }
+ return []
+}
+
+func matches(_ element: AXUIElement, candidates: [String]) -> Bool {
+ let role = stringAttribute(element, kAXRoleAttribute as CFString) ?? ""
+ let titles = titleCandidates(for: element)
+ guard !titles.isEmpty else { return false }
+ let interactiveRole = role == kAXButtonRole as String
+ || role == kAXRadioButtonRole as String
+ || role == kAXTabGroupRole as String
+ || role == kAXMenuItemRole as String
+ guard interactiveRole else { return false }
+ return titles.contains { title in
+ candidates.contains { candidate in
+ title == candidate || title.localizedCaseInsensitiveContains(candidate)
+ }
+ }
+}
+
+func findMatchingElement(
+ _ element: AXUIElement,
+ candidates: [String],
+ depth: Int,
+ visited: inout Set<CFHashCode>
+) -> AXUIElement? {
+ guard depth >= 0 else { return nil }
+ let hash = CFHash(element)
+ guard !visited.contains(hash) else { return nil }
+ visited.insert(hash)
+
+ if matches(element, candidates: candidates) {
+ return element
+ }
+
+ for child in children(of: element) {
+ if let match = findMatchingElement(child, candidates: candidates, depth: depth - 1, visited: &visited) {
+ return match
+ }
+ }
+ return nil
+}
+
+let candidates: [String]
+switch mode {
+case "data-tab":
+ candidates = ["Data"]
+case "export":
+ candidates = ["Export"]
+default:
+ fputs("FAIL: unknown settings action \(mode)\n", stderr)
+ exit(1)
+}
+
+var visited = Set<CFHashCode>()
+guard let element = findMatchingElement(root, candidates: candidates, depth: 12, visited: &visited) else {
+ fputs("FAIL: could not find settings control for \(mode)\n", stderr)
+ exit(1)
+}
+
+let result = AXUIElementPerformAction(element, kAXPressAction as CFString)
+guard result == .success else {
+ fputs("FAIL: could not press settings control for \(mode): \(result.rawValue)\n", stderr)
exit(1)
}
SWIFT
@@ -715,6 +878,14 @@
click_xy "$x" "$y"
}
+click_settings_control() {
+ local mode="$1"
+ if swift "$settings_ax_swift" "$mode" >/dev/null 2>&1; then
+ return 0
+ fi
+ click_relative_to_settings "$mode"
+}
+
click_overlay_outside_quick_search() {
local coords
coords="$(swift "$coords_swift" overlay-outside)"
@@ -752,11 +923,20 @@
return 1
}
+move_pointer_to_fullscreen_target() {
+ local coords
+ coords="$(swift "$coords_swift" fullscreen-target-center)"
+ read -r x y <<<"$coords"
+ move_xy "$x" "$y"
+ sleep 0.2
+}
+
log "==> Building app"
bash "$ROOT_DIR/build.sh" >/dev/null
log "==> Preparing QA defaults"
defaults write "$DEFAULTS_DOMAIN" showDockIcon -bool true
+defaults write "$DEFAULTS_DOMAIN" appLanguage -string en
reset_dock_for_qa
log "==> Starting clean app instance"
@@ -781,9 +961,9 @@
sleep 2.0
assert_single_qa_app_instance
assert_single_dock_tile
-send_keycode 53
+kill_all_taglauncher_instances
sleep 0.4
-wait_swift_assert no-overlay
+swift_assert no-overlay
log "==> QA split-view fullscreen geometry detection"
swift_assert split-geometry
@@ -794,9 +974,24 @@
defaults write "$DEFAULTS_DOMAIN" showDockIcon -bool "$dock_value"
prepare_isolated_app_instance
start_fullscreen_qa_target
+ move_pointer_to_fullscreen_target
send_main_hotkey
wait_swift_assert fullscreen-overlay
assert_fullscreen_overlay_stable
+ log "==> QA fullscreen Space: quick search from appgrid does not switch Space"
+ send_keycode 49
+ sleep 0.4
+ assert_fullscreen_overlay_stable
+ send_keycode 53
+ sleep 0.3
+ wait_swift_assert fullscreen-overlay
+ log "==> QA fullscreen Space: settings from appgrid does not switch Space"
+ send_cmd_comma
+ sleep 0.7
+ wait_swift_assert fullscreen-settings
+ close_settings_window
+ sleep 0.5
+ wait_swift_assert fullscreen-overlay
send_keycode 53
sleep 0.4
wait_swift_assert no-overlay
@@ -824,9 +1019,9 @@
swift_assert settings
log "==> QA 2/7: import/export file panel floats above settings"
-click_relative_to_settings data-tab
+click_settings_control data-tab
sleep 0.3
-click_relative_to_settings export
+click_settings_control export
sleep 0.7
swift_assert file-panel
send_keycode 53
--
Gitblit v1.9.3